Skip to content

test: stop containerd before accessing the stdout#4994

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
kzys:kill-before-buf
Feb 3, 2021
Merged

test: stop containerd before accessing the stdout#4994
dmcgowan merged 1 commit intocontainerd:masterfrom
kzys:kill-before-buf

Conversation

@kzys
Copy link
Copy Markdown
Member

@kzys kzys commented Feb 3, 2021

The variable buf is connected to containerd's stdout. So, accessing
the variable before killing containerd can cause a race condition.

Signed-off-by: Kazuyoshi Kato [email protected]

test: stop containerd before accessing the stdout
310e590 
The variable `buf` is connected to containerd's stdout. So, accessing
the variable before killing containerd can cause a race condition.

Signed-off-by: Kazuyoshi Kato <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 3, 2021

Build succeeded.

@kzys
Copy link
Copy Markdown
Member Author

kzys commented Feb 3, 2021

Is Docker Hub unhealthy now?

time="2021-02-03T18:16:41Z" level=info msg="running tests against containerd" revision=2f40b7890ca56e299b494d4d5ccb2cda6a80dc0b runtime=io.containerd.runtime.v1.linux version=2f40b78
time="2021-02-03T18:16:41Z" level=info msg="start to pull seed image" image="docker.io/library/alpine:latest"
failed to copy: httpReadSeeker: failed open: server message: invalid_token: authorization failed: time="2021-02-03T18:16:40.989236363Z" level=info msg="starting containerd" revision=2f40b7890ca56e299b494d4d5ccb2cda6a80dc0b version=2f40b78

@estesp
Copy link
Copy Markdown
Member

estesp commented Feb 3, 2021

Is Docker Hub unhealthy now?

Looks like it was, but I restarted another PR and integration is working properly. Will restart tests

estesp
estesp approved these changes Feb 3, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dmcgowan
dmcgowan approved these changes Feb 3, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit 4054230 into containerd:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kzys @estesp @dmcgowan