Skip to content

[release/1.3] runtime: fix shutdown runc v2 service#4992

Merged
fuweid merged 1 commit intocontainerd:release/1.3from
Iceber:fix-runc-v2-service-1.3
Feb 3, 2021
Merged

[release/1.3] runtime: fix shutdown runc v2 service#4992
fuweid merged 1 commit intocontainerd:release/1.3from
Iceber:fix-runc-v2-service-1.3

Conversation

@Iceber
Copy link
Copy Markdown
Member

@Iceber Iceber commented Feb 3, 2021 •
edited
Loading

Signed-off-by: IceberGu [email protected]
(cherry picked from commit b458583)
Signed-off-by: Iceber Gu [email protected]

Cherry-pick: #4988

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Feb 3, 2021

Hi @Iceber. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 3, 2021

Build succeeded.

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Feb 3, 2021

Hi, @Iceber IceberGu is your real name?

@Iceber
runtime: fix shutdown runc v2 service
fb872ce 
Signed-off-by: IceberGu <[email protected]>
(cherry picked from commit b458583)
Signed-off-by: Iceber Gu <[email protected]>
@Iceber Iceber force-pushed the fix-runc-v2-service-1.3 branch from 700997a to fb872ce Compare February 3, 2021 03:28
@Iceber
Copy link
Copy Markdown
Member Author

Iceber commented Feb 3, 2021

@fuweid updated

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Feb 3, 2021

Build succeeded.

fuweid
fuweid approved these changes Feb 3, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid merged commit 3405c1d into containerd:release/1.3 Feb 3, 2021
@Iceber Iceber deleted the fix-runc-v2-service-1.3 branch February 3, 2021 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@fuweid fuweid fuweid approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Iceber @k8s-ci-robot @fuweid @AkihiroSuda