Makefile: run "go mod tidy" when vendoring#4975
Merged
estesp merged 1 commit intocontainerd:masterfrom Jan 27, 2021
Merged
Conversation
2 tasks
AkihiroSuda
approved these changes
Jan 27, 2021
|
Build succeeded.
|
zhsj
reviewed
Jan 27, 2021
`make vendor` did not do a `go mod tidy` after vendoring, whereas CI does this as part of the vendor validation, causing CI to fail if `make vendor` was used to update vendoring, without doing a `go mod tidy` as well. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
|
LGTM |
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to #4717 (comment)
make vendordid not do ago mod tidyafter vendoring, whereas CI does this as part of the vendor validation, causing CI to fail ifmake vendorwas used to update vendoring, without doing ago mod tidyafterwards.