Allow moving netns directory into StateDir #4973
Conversation
|
Hi @lorenz. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
lorenz
force-pushed
the
move-netns-into-statedir
branch
2 times, most recently
from
b6315c0 to
b1d5c22
Compare
|
Build succeeded.
|
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
The default behavior should not change
|
Meaning I should gate this behind a setting? |
|
Yes, that seems safer to keep compatibility. |
|
@lorenz One question, what underlying system are you running on that does not have |
|
I still think this change is fine to make, we just need to make sure we are backward compatible in cause of a user upgrading containerd while pods are running. |
|
@crosbymichael This is a custom operating system being developed. It does not even have |
|
@AkihiroSuda Done, the new behavior is now gated behind |
|
Thanks, the code looks good but could you squash the commits |
|
Build succeeded.
|
Signed-off-by: Lorenz Brun <[email protected]>
lorenz
force-pushed
the
move-netns-into-statedir
branch
from
8afa66d to
36d0bc1
Compare
|
Done |
AkihiroSuda
changed the title
|
Build succeeded.
|
6 participants
The directory where cri puts the netns references is currently hardcoded. This moves it into StateDir which can be configured.
Having this configurable is useful for systems with read-only root filesystems where one needs tight controls over where software
is able to write to.