Skip to content

Move runtimeoptions out of cri package#4963

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
zhsj:move-runtimeopt
Jan 22, 2021
Merged

Move runtimeoptions out of cri package#4963
dmcgowan merged 1 commit intocontainerd:masterfrom
zhsj:move-runtimeopt

Conversation

@zhsj
Copy link
Copy Markdown
Contributor

@zhsj zhsj commented Jan 22, 2021

Since it's a standard set of runtime opts, and used in ctr as well,
it could be moved out of cri.

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Jan 22, 2021

Hi @zhsj. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhsj
Move runtimeoptions out of cri package
2818fde 
Since it's a standard set of runtime opts, and used in ctr as well,
it could be moved out of cri.

Signed-off-by: Shengjing Zhu <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jan 22, 2021

Build succeeded.

estesp
estesp approved these changes Jan 22, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; seems reasonable to have this non-specific to CRI

dmcgowan
dmcgowan approved these changes Jan 22, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@dmcgowan dmcgowan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit aae24ec into containerd:master Jan 22, 2021
@zhsj zhsj deleted the move-runtimeopt branch March 4, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhsj @k8s-ci-robot @dmcgowan @estesp