Derive cpuinfo as needed, instead of at init-time#4953
Merged
mxpv merged 1 commit intocontainerd:masterfrom Jan 19, 2021
Merged
Derive cpuinfo as needed, instead of at init-time#4953mxpv merged 1 commit intocontainerd:masterfrom
mxpv merged 1 commit intocontainerd:masterfrom
Conversation
|
Hi @imjasonh. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This changes platforms.Parse to hit /proc to look up CPU info only when it's needed, instead of in init(). This makes the package a bit easier for other packages to consume, especially clients that don't call platforms.Parse or need to lookup CPU info. Signed-off-by: Jason Hall <[email protected]>
Member
|
/ok-to-test |
|
Build succeeded.
|
samuelkarp
approved these changes
Jan 19, 2021
mxpv
approved these changes
Jan 19, 2021
Zyqsempai
approved these changes
Jan 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes
platforms.Parseto hit/procto look up CPU info only when it's needed, instead of ininit(). This makes the package a bit easier for other packages to consume, especially clients that don't callplatforms.Parseor need to lookup CPU info.This recently came up in google/go-containerregistry#916 since go-containerregistry imports moby/moby, which imports containerd/containerd/platforms to call
platforms.Parsewhen starting a container -- go-containerregistry never starts containers and doesn't care about the value ofplatforms.ParseorcpuInfo.cc @jonjohnsonjr