Skip to content

Add unit test for func in remotes/docker/pusher.go#4949

Merged
estesp merged 1 commit intocontainerd:masterfrom
hs0210:work
Mar 19, 2021
Merged

Add unit test for func in remotes/docker/pusher.go#4949
estesp merged 1 commit intocontainerd:masterfrom
hs0210:work

Conversation

@hs0210
Copy link
Copy Markdown
Contributor

@hs0210 hs0210 commented Jan 19, 2021

Signed-off-by: Hu Shuai [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Jan 19, 2021

Hi @hs0210. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jan 19, 2021

Build succeeded.

@kzys
Copy link
Copy Markdown
Member

kzys commented Mar 17, 2021

@estesp PTAL

/ok-to-test

@estesp estesp closed this Mar 18, 2021
@estesp estesp reopened this Mar 18, 2021
estesp
estesp approved these changes Mar 18, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; we can merge on green CI

@kzys
Copy link
Copy Markdown
Member

kzys commented Mar 19, 2021

@estesp It is green now :)

@estesp estesp merged commit 2061227 into containerd:master Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hs0210 @k8s-ci-robot @kzys @estesp