cri: add annotations for pod name and namespace#4922
Conversation
|
Hi @alban. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build succeeded.
|
|
I don't understand the error in the CI in the windows test:
This does not seem related to my change. |
|
@alban I'm running into the same and investigating on the Windows side, I'll update here if I find anything. It's hitting this (unless I'm missing something) on calling code that hasn't changed in quite a while so I'm a bit confused. It doesn't seem like any other recent PRs have ran into this besides me and you. |
|
This looks good. I actually have this change in a working set locally where I was needing the same information. Thank you for adding this! |
mikebrow
left a comment
mikebrow
left a comment
There was a problem hiding this comment.
Looking good just.. s/pod/sandbox/
cri-o has annotations for pod name, namespace and container name: https://github.com/containers/podman/blob/master/pkg/annotations/annotations.go But so far containerd had only the container name. This patch will be useful for seccomp agents to have a different behaviour depending on the pod (see runtime-spec PR 1074 and runc PR 2682). This should simplify the code in: https://github.com/kinvolk/seccompagent/blob/b2d423695d6dfc976d2456769acb19765a9d7524/pkg/kuberesolver/kuberesolver.go#L16-L27 Signed-off-by: Alban Crequy <[email protected]>
alban
force-pushed
the
alban_pod_annotations
branch
from
13a654d to
28e4fb2
Compare
|
Thanks! I rebased & updated the patch with the suggested renames. |
7 participants
cri-o has annotations for pod name, namespace and container name:
https://github.com/containers/podman/blob/master/pkg/annotations/annotations.go
But so far containerd had only the container name.
This patch will be useful for seccomp agents to have a different behaviour depending on the pod (see runtime-spec PR 1074 and runc PR 2682). This should simplify the code in:
https://github.com/kinvolk/seccompagent/blob/b2d423695d6dfc976d2456769acb19765a9d7524/pkg/kuberesolver/kuberesolver.go#L16-L27
Signed-off-by: Alban Crequy [email protected]
cc @rata @mauriciovasquezbernal