Hi @liusdu. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Build succeeded.

• containerd-build-arm64 : SUCCESS in 5m 48s (non-voting)

Build succeeded.

• containerd-build-arm64 : SUCCESS in 5m 39s (non-voting)

I only see this issue when I shutdown the integration testing manually, because the TestMain uses pipe to read the debug-log-mode testing-containerd process. The testing-containerd process will be leaky and receive the SIG_PIPE broken event and repeat it...

I only see this issue when I shutdown the integration testing manually, because the TestMain uses pipe to read the debug-log-mode testing-containerd process. The testing-containerd process will be leaky and receive the SIG_PIPE broken event and repeat it...

Hi @fuweid , I encounter this issue when system journal has been rotated, with messageWarning: Journal has been rotated since unit was started. Log output is incomplete or unavailable. in output of systemctl status dockerd. In this situation containerd writes to the breakpipe, which cause nested signals. The strace output is as following

3084323 12:31:24 write(2, "time=\"2021-01-12T12:31:24.841183276+08:00\" level=debug msg=\"received signal\" signal=broken pipe \n", 97 <unfinished ...>
3081094 12:31:24 futex(0x55b8417a2680, FUTEX_WAIT, 0, NULL <unfinished ...>
3084323 12:31:24 <... write resumed> )  = -1 EPIPE (Broken pipe) <0.000021>
3084323 12:31:24 --- SIGPIPE {si_signo=SIGPIPE, si_code=SI_USER, si_pid=1298888, si_uid=0} ---
3084323 12:31:24 futex(0x55b8417a2680, FUTEX_WAKE, 1) = 1 <0.000029>
3081094 12:31:24 <... futex resumed> )  = 0 <0.000111>
3084323 12:31:24 rt_sigreturn( <unfinished ...>
3081094 12:31:24 futex(0x55b8417a2680, FUTEX_WAIT, 0, NULL <unfinished ...>
3084323 12:31:24 <... rt_sigreturn resumed> ) = -1 EPIPE (Broken pipe) <0.000021>
3084323 12:31:24 futex(0x55b8417a2680, FUTEX_WAKE, 1) = 1 <0.000033>
3081094 12:31:24 <... futex resumed> )  = 0 <0.000097>
3084323 12:31:24 write(2, "Failed to write to log, write /dev/stderr: broken pipe\n", 55 <unfinished ...>
3081094 12:31:24 futex(0x55b8417a2680, FUTEX_WAIT, 0, NULL <unfinished ...>
3084323 12:31:24 <... write resumed> )  = -1 EPIPE (Broken pipe) <0.000020>

@liusdu thanks for the information. What version of docker are you using right now? Is it that the dockerd starts containerd instead of containerd.service?

Build succeeded.

• containerd-build-arm64 : RETRY_LIMIT in 1m 00s (non-voting)

Yes, I use dockerd as container engine.

docker version
Client:
 Version:           18.06.3-ce
 API version:       1.38
 Go version:        go1.10.4
 Git commit:        d7080c1
 Built:             Wed Feb 20 02:24:22 2019
 OS/Arch:           linux/amd64
 Experimental:      false

Server:
 Engine:
  Version:          18.06.3-ce
  API version:      1.38 (minimum version 1.12)
  Go version:       go1.10.3
  Git commit:       d7080c1
  Built:            Wed Feb 20 02:25:33 2019
  OS/Arch:          linux/amd64
  Experimental:     false

@liusdu The change is LGTM. Could you add some comment about the case mentioned by @thaJeztah ? Thanks