Allow passing environent variables to StreamProcessors#4916
Allow passing environent variables to StreamProcessors#4916mxpv merged 1 commit intocontainerd:masterfrom
Conversation
|
Hi @stefanberger. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build succeeded.
|
There was a problem hiding this comment.
Nit: Envs -> Env.
In my understanding "an environment" means a set of variables, not a single variable
There was a problem hiding this comment.
I now renamed all occurrences of 'Envs' and 'envs' and removed the trailing 's'.
There was a problem hiding this comment.
Envs -> Env (so field name corresponds to toml)
There was a problem hiding this comment.
oooh, I though I had replaced them all. Thanks!
stefanberger
force-pushed
the
streamproc_env_vars
branch
from
3e5d953 to
b379b0f
Compare
|
Build succeeded.
|
|
Are these test failures related to this change? They don't look to be.. |
Add support for an 'env' field to the StreamProcessor configuration and append the environment variables found there to the os.Environ() array. The env field takes environment variables in the form of key=value. Signed-off-by: Stefan Berger <[email protected]>
stefanberger
force-pushed
the
streamproc_env_vars
branch
from
b379b0f to
1917ca5
Compare
|
Build succeeded.
|
6 participants
Add support for an 'envs' field to the StreamProcessor configuration
and append it to the os.Environ() array.
The envs field takes environment variables in the form of key=value.
Signed-off-by: Stefan Berger [email protected]