[Carry] mount: handle loopback mount#4902
Merged
estesp merged 4 commits intocontainerd:masterfrom Jan 8, 2021
Merged
Conversation
If a mount has specified `loop` option, we need to handle it on our own instead of passing it to the kernel. In such case, create a loopback device, attach the mount source to it, and mount the loopback device rather than the mount source. Signed-off-by: Peng Tao <[email protected]>
No need to use the private losetup command line wrapper package. The generic package provides the same functionality. Signed-off-by: Peng Tao <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
AkihiroSuda
reviewed
Jan 5, 2021
Member
There was a problem hiding this comment.
200 seems too large. I suggest 100.
Signed-off-by: Maksym Pavlenko <[email protected]>
|
Build succeeded.
|
AkihiroSuda
approved these changes
Jan 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR carries changes from #4178 (and addresses comments). This (hopefully) should also address flaky test with losetup #4897
cc: @bergwolf @zhsj @AkihiroSuda