Skip to content

docs: point cri release tarball to github release page#4899

Merged
mxpv merged 1 commit intocontainerd:masterfrom
zhsj:cri-install-doc
Jan 4, 2021
Merged

docs: point cri release tarball to github release page#4899
mxpv merged 1 commit intocontainerd:masterfrom
zhsj:cri-install-doc

Conversation

@zhsj
Copy link
Copy Markdown
Contributor

@zhsj zhsj commented Jan 3, 2021

Closes: #4867

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Jan 3, 2021

Hi @zhsj. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jan 3, 2021

Build succeeded.

mxpv
mxpv approved these changes Jan 4, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

losetup_test.go:96: assertion failed: expected [/dev/loop5] (length 1) to have length 0 is unrelated. let's have this in.

@mxpv mxpv merged commit 5d1955a into containerd:master Jan 4, 2021
@zhsj zhsj deleted the cri-install-doc branch January 5, 2021 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxpv mxpv mxpv approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

+1 more reviewer

@Zyqsempai Zyqsempai Zyqsempai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Release tarball in GCS

5 participants

@zhsj @k8s-ci-robot @mxpv @Zyqsempai @AkihiroSuda