Skip to content

standard makefile,fix not work no macos#4898

Merged
mxpv merged 1 commit intocontainerd:masterfrom
timchenxiaoyu:makefile
Mar 19, 2021
Merged

standard makefile,fix not work no macos#4898
mxpv merged 1 commit intocontainerd:masterfrom
timchenxiaoyu:makefile

Conversation

@timchenxiaoyu
Copy link
Copy Markdown
Contributor

@timchenxiaoyu timchenxiaoyu commented Jan 2, 2021

on macos , make binaries not compile contained

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Jan 2, 2021

Hi @timchenxiaoyu. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jan 2, 2021

Build succeeded.

@mxpv
Copy link
Copy Markdown
Member

mxpv commented Jan 2, 2021

Could you please sign off your commits (try git commit -s) in order to pass CI checks?
https://github.com/containerd/project/blob/master/CONTRIBUTING.md#sign-your-work

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Jan 4, 2021

Build succeeded.

@timchenxiaoyu
Copy link
Copy Markdown
Contributor Author

timchenxiaoyu commented Jan 4, 2021

tks, already signed off.

@timchenxiaoyu
Copy link
Copy Markdown
Contributor Author

timchenxiaoyu commented Jan 4, 2021

irrelevant failed test
Error: losetup_test.go:96: assertion failed: expected [/dev/loop3] (length 1) to have length 0

kzys
kzys requested changes Jan 11, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@kzys kzys left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good.

Regarding the commit message, calling this change "standard" is a bit of stretch. As far as I know, macOS has GNU make. Neither define ... endef nor $(call ...) are in standards such as POSIX.

@timchenxiaoyu
Copy link
Copy Markdown
Contributor Author

timchenxiaoyu commented Jan 12, 2021 •
edited
Loading

I know, tks for your explanation!

crosbymichael
crosbymichael approved these changes Feb 4, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@crosbymichael crosbymichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxpv mxpv merged commit a47feaf into containerd:master Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kzys kzys kzys requested changes

@crosbymichael crosbymichael crosbymichael approved these changes

@mxpv mxpv mxpv approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@timchenxiaoyu @k8s-ci-robot @mxpv @kzys @crosbymichael