Skip to content

Add platforms.Only test#4879

Merged
estesp merged 1 commit intocontainerd:masterfrom
tianon:platforms-only-test
Dec 28, 2020
Merged

Add platforms.Only test#4879
estesp merged 1 commit intocontainerd:masterfrom
tianon:platforms-only-test

Conversation

@tianon
Copy link
Copy Markdown
Member

@tianon tianon commented Dec 23, 2020

This adds a test for platforms.Only (previously untested, as far as I can tell).

(This is the hopefully less-controversial part of #4528? 😅 ❤️)

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Dec 23, 2020

Build succeeded.

@tianon tianon force-pushed the platforms-only-test branch from 8f39960 to 7d8b50e Compare December 23, 2020 22:05
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Dec 23, 2020

Build succeeded.

@tianon
Copy link
Copy Markdown
Member Author

tianon commented Dec 23, 2020

(Test failures are unrelated.)

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

left one suggestion

Comment thread platforms/compare_test.go Outdated
This adds a test for `platforms.Only` (previously untested, as far as I can tell).

Signed-off-by: Tianon Gravi <[email protected]>
@tianon tianon force-pushed the platforms-only-test branch from 7d8b50e to 66a3f2c Compare December 23, 2020 22:54
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Dec 23, 2020

Build succeeded.

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 7a2720f into containerd:master Dec 28, 2020
@tianon tianon deleted the platforms-only-test branch December 28, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants