[release/1.4 backport] Return GRPC not found error instead of plain one#4872
Conversation
|
Hi @danail-branekov. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build succeeded.
|
AkihiroSuda
left a comment
AkihiroSuda
left a comment
There was a problem hiding this comment.
Please use git cherry-pick -x to clarify the master commit https://git-scm.com/docs/git-cherry-pick
When the shim returns a plain error when a process does not exist, the server is unable to recognise its GRPC status code and assumes UnknownError. This is awkward for containerd client users as they are unable to recognise the actual reason for the error. When the shim returns a NotFound GRPC error, it is properly translated by the server and clients receive a proper NotFound error instead of Unknown Co-authored-by: Danail Branekov <[email protected]> Co-authored-by: Georgi Sabev <[email protected]> Signed-off-by: Danail Branekov <[email protected]> Signed-off-by: Georgi Sabev <[email protected]> (cherry picked from commit 7451dd1)
danail-branekov
force-pushed
the
pr-process-not-found-err-14
branch
from
847e7e9 to
8cff6b3
Compare
|
Done, cherry-picked with the |
|
Build succeeded.
|
|
Linking the master PR: #4860 (Merged on Dec 22) |
4 participants
When the shim returns a plain error when a process does not exist,
the server is unable to recognise its GRPC status code and assumes
UnknownError. This is awkward for containerd client users as they are
unable to recognise the actual reason for the error.
When the shim returns a NotFound GRPC error, it is properly translated
by the server and clients receive a proper NotFound error instead of
Unknown
Co-authored-by: Danail Branekov [email protected]
Co-authored-by: Danail Branekov [email protected]
Signed-off-by: Danail Branekov [email protected]
Signed-off-by: Georgi Sabev [email protected]