Update BUILDING.md after moving to Go modules and various other small docs update#4866
Update BUILDING.md after moving to Go modules and various other small docs update#4866estesp merged 5 commits intocontainerd:masterfrom
Conversation
|
Hi @zhsj. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build succeeded.
|
There was a problem hiding this comment.
GOPATH is removed intentionally. For newcomers of Go, they don't need to be aware of GOPATH. So the runc source is cloned via git, not go get.
There was a problem hiding this comment.
Needs docker volume create somewhere, no?
There was a problem hiding this comment.
Missing the absolute path... I was thinking about passing the source dir cloned in previous step.
There was a problem hiding this comment.
Using go get to install things is confused. It will accidentally touch your go.mod. After go1.16, it will be improved, but the command is not right then, it needs to be go install github.com/opencontainers/runc@version.
So currently keeping the old things from GOPATH doesn't feel beneficial.
Signed-off-by: Shengjing Zhu <[email protected]>
Signed-off-by: Shengjing Zhu <[email protected]>
No longer used Signed-off-by: Shengjing Zhu <[email protected]>
Signed-off-by: Shengjing Zhu <[email protected]>
Signed-off-by: Shengjing Zhu <[email protected]>
|
Build succeeded.
|
6 participants
No description provided.