[cri] ensure log dir is created#4863
Merged
estesp merged 1 commit intocontainerd:masterfrom Dec 18, 2020
Merged
Conversation
containerd is responsible for creating the log but there is no code to ensure that the log dir exists. While kubelet should have created this there can be times where this is not the case and this can cause stuck tasks. Signed-off-by: Michael Crosby <[email protected]>
dims
reviewed
Dec 17, 2020
Member
Author
|
looks like the openlab check got stuck.... |
Member
Author
|
Does anyone think this should be a back port? |
Member
yes.. maybe also to _other, _windows (or todo) |
fuweid
approved these changes
Dec 18, 2020
Member
fuweid
left a comment
fuweid
left a comment
There was a problem hiding this comment.
LGTM
windows/other cases can be handled in the followup
AkihiroSuda
approved these changes
Dec 18, 2020
Member
|
Cherry-picked in containerd/cri#1618 (needs containerd/cri to be re-vendored) |
AkihiroSuda
added
cherry-picked/1.4.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
containerd is responsible for creating the log but there is no code to ensure
that the log dir exists. While kubelet should have created this there can be
times where this is not the case and this can cause stuck tasks.
Signed-off-by: Michael Crosby [email protected]