Update hcsshim and go-winio vendoring #4859
Conversation
|
Hi @dcantah. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Nevermind. From CI failure, looks like go.mod may not be fully up to date. Can you double check that? |
dcantah
force-pushed
the
update-hcsshim-winio
branch
from
6ac6dc6 to
b3e05d1
Compare
|
@kevpar Done! |
|
Looks like we have some more failures. Not sure about the Linux ones, but the Windows one is probably that we nil-dereference when no shim options are passed here: https://github.com/microsoft/hcsshim/blob/master/cmd/containerd-shim-runhcs-v1/task_hcs.go#L153 |
|
Linux ones seem to be the same old devmapper and loop device ones that keep failing, but yep that seems to be the culprit. I'll push a fix |
dcantah
force-pushed
the
update-hcsshim-winio
branch
3 times, most recently
from
e61248a to
f0a99d5
Compare
|
Line ending issue because one of the checked in files in our repo is crlf. Fixing shortly Edit: Fixed 😄 |
dcantah
force-pushed
the
update-hcsshim-winio
branch
from
f0a99d5 to
8f0d3ee
Compare
|
Build succeeded.
|
* Update hcsshim to v0.8.14 * Update go-winio to v0.4.16 This brings in some vhd package changes from winio, and the compute storage api bindings for the shim. This is to facilitate some coming functionality for the windows snapshotter as well as possibly for future work down the line for the windows differ. Signed-off-by: Daniel Canter <[email protected]>
dcantah
force-pushed
the
update-hcsshim-winio
branch
from
8f0d3ee to
a551492
Compare
|
Build succeeded.
|
* Currently we rely on making the UVMs sandbox.vhdx in the shim itself instead of this being made by the snapshotter itself. This change adds a label that affects whether to create the UVMs scratch layer in the snapshotter itself. * Adds container scratch size customization. Before adding the computestorage calls (vendored in with containerd#4859) there was no way to make a containers or UVMs scratch size less than the default (20 for containers and 10 for the UVM). Signed-off-by: Daniel Canter <[email protected]>
* Currently we rely on making the UVMs sandbox.vhdx in the shim itself instead of this being made by the snapshotter itself. This change adds a label that affects whether to create the UVMs scratch layer in the snapshotter itself. * Adds container scratch size customization. Before adding the computestorage calls (vendored in with containerd#4859) there was no way to make a containers or UVMs scratch size less than the default (20 for containers and 10 for the UVM). Signed-off-by: Daniel Canter <[email protected]>
5 participants
This brings in some vhd package changes from winio, and the compute storage api bindings for
the shim. This is to facilitate some coming functionality for the windows snapshotter
as well as possibly for future work down the line for the windows differ.
Signed-off-by: Daniel Canter [email protected]