Skip to content

pusher: add missing authentication support for requests#4854

Merged
AkihiroSuda merged 1 commit intocontainerd:masterfrom
tonistiigi:fix-push-auth
Dec 16, 2020
Merged

pusher: add missing authentication support for requests#4854
AkihiroSuda merged 1 commit intocontainerd:masterfrom
tonistiigi:fix-push-auth

Conversation

@tonistiigi
Copy link
Copy Markdown
Member

fix #4622

@howardjohn

Signed-off-by: Tonis Tiigi [email protected]

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda
Copy link
Copy Markdown
Member

Openlab CI isn't responding. Merging.

@AkihiroSuda AkihiroSuda merged commit 7fa02f3 into containerd:master Dec 16, 2020
jrajahalme added a commit to cilium/proxy that referenced this pull request Dec 21, 2020
Add support for $(DOCKER_DEV_ACCOUNT) defaulting to "quay.io/cilium".

This is needed if the builder has no access to "quay.io/cilium". Also
helps circumvent buildx auth problem
(containerd/containerd#4622) with quay.io
before this fix is available:
containerd/containerd#4854.

Signed-off-by: Jarno Rajahalme <[email protected]>
jrajahalme added a commit to cilium/proxy that referenced this pull request Dec 21, 2020
Add support for $(DOCKER_DEV_ACCOUNT) defaulting to "quay.io/cilium".

This is needed if the builder has no access to "quay.io/cilium". Also
helps circumvent buildx auth problem
(containerd/containerd#4622) with quay.io
before this fix is available:
containerd/containerd#4854.

Signed-off-by: Jarno Rajahalme <[email protected]>
jrajahalme added a commit to cilium/proxy that referenced this pull request Dec 22, 2020
Add support for $(DOCKER_DEV_ACCOUNT) defaulting to "quay.io/cilium".

This is needed if the builder has no access to "quay.io/cilium". Also
helps circumvent buildx auth problem
(containerd/containerd#4622) with quay.io
before this fix is available:
containerd/containerd#4854.

Signed-off-by: Jarno Rajahalme <[email protected]>
@thaJeztah thaJeztah added cherry-picked/1.4.x PR commits are cherry picked into the release/1.4 branch and removed cherry-pick/1.4.x labels Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked/1.4.x PR commits are cherry picked into the release/1.4 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pusher does not authenticate properly for gcr

5 participants