Skip to content

Update RUNC.md#4850

Merged
estesp merged 1 commit intocontainerd:masterfrom
wangmaodou:update-runc-doc
Dec 15, 2020
Merged

Update RUNC.md#4850
estesp merged 1 commit intocontainerd:masterfrom
wangmaodou:update-runc-doc

Conversation

@wangmaodou
Copy link
Copy Markdown

@wangmaodou wangmaodou commented Dec 15, 2020

Hi, I found the link is 404 while reading doc, so update it :)

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Dec 15, 2020

Hi @wangmaodou. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Dec 15, 2020

Build succeeded.

@estesp
Copy link
Copy Markdown
Member

estesp commented Dec 15, 2020

Thanks for finding this! Can you please sign your commit and re-push so that our CI checks can pass?

docs: update RUNC.md
b197a66 
Signed-off-by: maodou <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Dec 15, 2020

Build succeeded.

@wangmaodou wangmaodou closed this Dec 15, 2020
@wangmaodou wangmaodou reopened this Dec 15, 2020
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Dec 15, 2020

Build succeeded.

estesp
estesp approved these changes Dec 15, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 0c0ff6e into containerd:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wangmaodou @k8s-ci-robot @estesp @AkihiroSuda