update the docs to version=2 #4836
Conversation
|
Hi @QFREEE. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build succeeded.
|
|
Your commits must have DCO ( |
|
@QFREEE are you able to squash your commits and add the sign off. Please reach out if you have question or want any guidance on that! |
dmcgowan
added
status/needs-update
| **no_shim** specifies whether to use a shim or not (Default: **false**), | ||
| **shim_debug** turns on debugging for the shim (Default: **false**) | ||
| - **[plugins.scheduler]** has several options that perform advanced tuning for the scheduler: | ||
| - **[plugins.io.containerd.gc.v1.scheduler]** has several options that perform advanced tuning for the scheduler: |
There was a problem hiding this comment.
The plugin name needs double quotes
| ## FORMAT | ||
|
|
||
| **version** | ||
| : The version of the config file |
There was a problem hiding this comment.
Can we have some explanation about v1 and v2?
|
@QFREEE looks like this needs a rebase; could you also have a look at the review comments? |
|
ping @QFREEE |
|
Closing in favor of #6125 |
7 participants
updated the docs to config version=2. #4426
However, We are not sure where to find the exact config struct and descriptions for plugins and timeouts. Can you guide me on where to find descriptions apart from https://github.com/QFREEE/containerd/blob/master/services/server/config/config.go ?
We also found these timeout properties from other configs, however we are not sure where exactly they are coming from.[timeouts] "io.containerd.timeout.shim.cleanup" = "5s" "io.containerd.timeout.shim.load" = "5s" "io.containerd.timeout.shim.shutdown" = "3s" "io.containerd.timeout.task.state" = "2s"
commit history:
QFREEE@7fa35db
QFREEE@4ce9575