Skip to content

[cri] add a second parameter to check if fsnotify watcher closed#4825

Closed
abel-von wants to merge 1 commit intocontainerd:masterfrom
abel-von:master
Closed

[cri] add a second parameter to check if fsnotify watcher closed#4825
abel-von wants to merge 1 commit intocontainerd:masterfrom
abel-von:master

Conversation

@abel-von
Copy link
Copy Markdown
Contributor

@abel-von abel-von commented Dec 10, 2020

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Dec 10, 2020

Hi @abel-von. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abel-von abel-von mentioned this pull request Dec 10, 2020
Closed
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Dec 10, 2020

Build succeeded.

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Dec 10, 2020

FAIL - does not have a valid DCO

Please git commit -s --amend to sign off and adjust your commit message. And repush it. Thanks

@fuweid fuweid added the status/needs-update Awaiting contributor update label Jan 12, 2021
@fuweid
Copy link
Copy Markdown
Member

fuweid commented Jan 28, 2021

ping @abel-von ~ Would you mind to update your commit? Thanks

@fuweid fuweid added this to the 1.5 milestone Jan 28, 2021
@fuweid
Copy link
Copy Markdown
Member

fuweid commented Feb 17, 2021

@abel-von Would you mind to update the pr? Thank you!

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Mar 3, 2021

@abel-von since we need this patch in coming release 1.5, I carry your commit in #5116. sorry for any inconvenient!

@fuweid fuweid mentioned this pull request Mar 3, 2021
Merged
@estesp estesp closed this in #5116 Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-ok-to-test status/needs-update Awaiting contributor update

Projects

None yet

Milestone

1.5

Development

Successfully merging this pull request may close these issues.

3 participants

@abel-von @k8s-ci-robot @fuweid