Skip to content

Build on FreeBSD#4822

Merged
estesp merged 3 commits intocontainerd:masterfrom
samuelkarp:freebsd
Dec 11, 2020
Merged

Build on FreeBSD#4822
estesp merged 3 commits intocontainerd:masterfrom
samuelkarp:freebsd

Conversation

@samuelkarp
Copy link
Copy Markdown
Member

@samuelkarp samuelkarp commented Dec 9, 2020

This PR updates continuity to include containerd/continuity#173 and updates containerd to compile for FreeBSD. The built containerd and ctr binaries run, with some plugins not yet loading.

% sudo ctr plugin ls
TYPE                            ID                       PLATFORMS        STATUS    
io.containerd.content.v1        content                  -                ok        
io.containerd.snapshotter.v1    native                   freebsd/amd64    ok        
io.containerd.metadata.v1       bolt                     -                ok        
io.containerd.differ.v1         walking                  freebsd/amd64    ok        
io.containerd.gc.v1             scheduler                -                ok        
io.containerd.service.v1        introspection-service    -                ok        
io.containerd.service.v1        containers-service       -                ok        
io.containerd.service.v1        content-service          -                ok        
io.containerd.service.v1        diff-service             -                ok        
io.containerd.service.v1        images-service           -                ok        
io.containerd.service.v1        leases-service           -                ok        
io.containerd.service.v1        namespaces-service       -                ok        
io.containerd.service.v1        snapshots-service        -                ok        
io.containerd.runtime.v2        task                     freebsd/amd64    ok        
io.containerd.service.v1        tasks-service            -                error     
io.containerd.internal.v1       restart                  -                error     
io.containerd.grpc.v1           containers               -                ok        
io.containerd.grpc.v1           content                  -                ok        
io.containerd.grpc.v1           diff                     -                ok        
io.containerd.grpc.v1           events                   -                ok        
io.containerd.grpc.v1           healthcheck              -                ok        
io.containerd.grpc.v1           images                   -                ok        
io.containerd.grpc.v1           leases                   -                ok        
io.containerd.grpc.v1           namespaces               -                ok        
io.containerd.internal.v1       opt                      -                ok        
io.containerd.grpc.v1           snapshots                -                ok        
io.containerd.grpc.v1           tasks                    -                error     
io.containerd.grpc.v1           version                  -                ok

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Dec 9, 2020

Build succeeded.

AkihiroSuda
AkihiroSuda reviewed Dec 9, 2020
View reviewed changes
Comment thread cmd/containerd-shim/shim_freebsd.go
runc.Monitor = reaper.Default
return signals, nil
}

Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda Dec 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure we want to maintain shim v1 for non-linux

Copy link
Copy Markdown
Member Author

@samuelkarp samuelkarp Dec 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, though right now I was just trying to fix compilation errors as the existing code fails to compile.

@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Dec 9, 2020

Are we going to get a shim implementation for jail(8)? 👀

@samuelkarp
Copy link
Copy Markdown
Member Author

samuelkarp commented Dec 9, 2020

Are we going to get a shim implementation for jail(8)? 👀

Maybe...depends on what my free time looks like 😄 (I'm exploring on my personal time not work time). Though I suspect that we wouldn't want an in-tree shim implementation for jail(8) yet as it would imply a bit more about supported use-cases than I think y'all are ready to take on. Fortunately, out-of-tree, out-of-process shim plugins are already a supported use-case, so I can implement something without having to imply that the containerd project officially supports FreeBSD jails.

mxpv
mxpv approved these changes Dec 9, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp
Copy link
Copy Markdown
Member

estesp commented Dec 10, 2020

Seems like if we accept this we should also add the cross-compile to some part of the GH Actions CI to keep this at least in compilable state? Similar to what was added to continuity

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Dec 11, 2020

Build succeeded.

@samuelkarp
Copy link
Copy Markdown
Member Author

samuelkarp commented Dec 11, 2020

@estesp Done

estesp
estesp approved these changes Dec 11, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit fad0ca2 into containerd:master Dec 11, 2020
@kzys kzys mentioned this pull request Mar 25, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxpv mxpv mxpv approved these changes

@estesp estesp estesp approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@samuelkarp @AkihiroSuda @estesp @mxpv