Enable devmapper tests#4821
Merged
crosbymichael merged 3 commits intocontainerd:masterfrom Dec 14, 2020
Merged
Conversation
mxpv
force-pushed
the
tests
branch
2 times, most recently
from
369e1cb to
c15303c
Compare
mxpv
force-pushed
the
tests
branch
2 times, most recently
from
66b1599 to
e73760c
Compare
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
Signed-off-by: Maksym Pavlenko <[email protected]>
|
Build succeeded.
|
samuelkarp
approved these changes
Dec 10, 2020
estesp
approved these changes
Dec 10, 2020
Member
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
LGTM
@renzhengeek : do you have the opportunity to validate this change in your environment?
kzys
reviewed
Dec 10, 2020
|
|
||
| // Don't spam logs | ||
| if attempt%10 == 0 { | ||
| log.G(ctx).WithError(retryErr).Warnf("retrying... (%d of %d)", attempt, maxRetries) |
Member
There was a problem hiding this comment.
This is from the original code, but how about logging the total number of retries at the end? The current implementation could log retrying... (10 of 100) even if retries 19 times.
Member
Author
There was a problem hiding this comment.
I don't know if there is any value in this information. BUSY related errors are usually hard to measure, and if it takes 19 attempts on one instance, doesn't mean that the same will apply on another one. This warning is more to convey that we're doing something more than 10 times and we'll likely be failing anyway.
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables the devmapper tests back (after disabling them in #4719 (comment))
We have included a few patches recently that affected unit tests:
Signed-off-by: Maksym Pavlenko [email protected]