Skip to content

ctr: FetchConfig: allow setting additional []containerd.RemoteOpt#4820

Merged
fuweid merged 1 commit intocontainerd:masterfrom
AkihiroSuda:additional-pull-opts
Dec 9, 2020
Merged

ctr: FetchConfig: allow setting additional []containerd.RemoteOpt#4820
fuweid merged 1 commit intocontainerd:masterfrom
AkihiroSuda:additional-pull-opts

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

The additional []containerd.RemoteOpt is not used by ctr currently, but planned to be used by nerdctl and also probably by stargz's ctr-remote.

The additional []containerd.RemoteOpt is not used by ctr currently,
but planned to be used by nerdctl and also probably by stargz's ctr-remote.

Signed-off-by: Akihiro Suda <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Dec 9, 2020

Build succeeded.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@fuweid fuweid merged commit 7b0149a into containerd:master Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants