Hi @ungureanuvladvictor. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Build succeeded.

• containerd-build-arm64 : SUCCESS in 5m 32s (non-voting)

Build succeeded.

• containerd-build-arm64 : SUCCESS in 5m 37s (non-voting)

Build succeeded.

• containerd-build-arm64 : SUCCESS in 5m 52s (non-voting)

LGTM, but please consider squashing commits

Build succeeded.

• containerd-build-arm64 : SUCCESS in 5m 55s (non-voting)

# https://github.com/containerd/containerd/blob/master/cmd/containerd/command/main.go#L54
func init() {
	logrus.SetFormatter(&logrus.TextFormatter{
		TimestampFormat: log.RFC3339NanoFixed,
		FullTimestamp:   true,
	})

Could we remove this part?

@fuweid -- addressed your comment!

Build succeeded.

• containerd-build-arm64 : SUCCESS in 5m 37s (non-voting)

I recompiled and replaced the containerd of the node, and then restarted the containerd service. However, the container log is still in text format and has not been changed to json format.

I adjusted this part of the configuration：
[debug] address = "" uid = 0 gid = 0 level = "" format = "json"

@weekyuan -- I gave your config a test with 318e34b and I see the logs in JSON format. My debug block is in this format:

[debug]
  address = ""
  uid = 0
  gid = 0
  level = ""
  format = "json"

Hi @ungureanuvladvictor, I am new to using containerd and am also trying to change the logging output to JSON. I am using containerd v1.5.6 and edited the debug block as you suggested and I am not seeing JSON output in /var/log/containers/<container.log>.

Am i misunderstanding what this enhancement does? I also have not been able to find any documentation on this new setting. Any help would be appreciated.

Thanks!

@bekirby -- this feature is for the logs of containerd itself and not the log format of the containers that are running.

@ungureanuvladvictor just happened to be on and saw your reply - thank you. Is it possible to change the log format of the containers do you know? We are switching from Docker to containerd and that is one of the problems we are facing.

As far as I know this is not possible right now but I'd suggest asking this on the #containerd slack chan -- maybe more folks know this.

Some relevant issues + links:

• JSON format support for container logs #3955
• Support pluggable logging #6639
• https://github.com/kubernetes/community/blob/master/contributors/design-proposals/node/kubelet-cri-logging.md

Thank you very much for the info!

I think to do plug-able logging format for kubelet CRI containers we would need a KEP see github.com/kubernetes/enhancements