Mention built-in CRI support in README#4796
Mention built-in CRI support in README#4796mxpv merged 2 commits intocontainerd:masterfrom jsj:jsj/4572
Conversation
|
Hi @jsj. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build succeeded.
|
|
Build succeeded.
|
estesp
left a comment
estesp
left a comment
There was a problem hiding this comment.
I realize you simply copied the existing README.md section from the original, but it would be nice to clean up some of the grammar/usage as we copy it in.
If you would prefer not to in your PR, we can do it as a follow-up. Thanks!
There was a problem hiding this comment.
of the Kubernetes [container runtime..
There was a problem hiding this comment.
I don't think this needs to be separated by a paragraph break from the opening sentence above; following re-wording suggested:
With the cri plugin you are able to use containerd as the container runtime for a Kubernetes cluster.
There was a problem hiding this comment.
Suggested:
Since containerd 1.1, the cri plugin is built into the release binaries and enabled by default.
There was a problem hiding this comment.
Maybe remove the starting cri and just start "As of containerd 1.5, the .."
There was a problem hiding this comment.
"The cri plugin has reached GA status, representing that it is:"
then you can drop the "It [is]" from the bullets and instead have:
- Feature complete
- Works with Kubernetes 1.10 and above
- Passes all ..
There was a problem hiding this comment.
See results on the containerd k8s [test dashboard.. ?
There was a problem hiding this comment.
for this and the next doc reference, can we make it "refer [to this kube-up guide].."
(the next one would be something like "refer [to the ansible document]..")
|
Build succeeded.
|
Signed-off-by: James Jackson <[email protected]>
* Consolidating and improving language Signed-off-by: James Jackson <[email protected]>
|
Build succeeded.
|
5 participants
containder/containerd changes for #4572
Some of the commands mentioned in the old cri README are now outdated with the integration.
Such as the build tags, way to install dependencies, running a Kubernetes local cluster with ./hack/local-up-cluster.sh
So reduced scope of Getting Started for Developers section