[cri/config] : fix range iterator issue in ValidatePluginConfig#4772
Conversation
|
Hi @gaurav1086. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build succeeded.
|
95fda97 to
8ade062
Compare
|
Build succeeded.
|
|
Please sign your commit to pass CI validation |
8ade062 to
60f2fe7
Compare
|
Build succeeded.
|
|
@estesp The error appears to be: FAIL - commit subject exceeds 90 characters . Is there a character limit on the subject ? |
|
yes, commit messages should start with a short "subject" line, then a blank line and then any more informative/descriptive text and then sign-off. In your case because that string of text just continues into a full sentence it breaks the 90-char limit check. The title of this PR would be a better commit subject and the current text should be the longer detail. Example: |
Go uses the same address variable while iterating in a range, so use a copy when using its address. Signed-off-by: Gaurav Singh <[email protected]>
60f2fe7 to
071a185
Compare
|
Thanks @estesp . Changes made. |
|
Build succeeded.
|
|
LGTM |
Go uses the same address variable while iterating in a range, so use a copy when using its address.
Sample code to highlight the issue: https://play.golang.org/p/YSqm1Gu3O0i