Skip to content

Remove duplicate systemd units file#4764

Merged
estesp merged 1 commit intocontainerd:masterfrom
zhsj:cleanup-systemd
Nov 25, 2020
Merged

Remove duplicate systemd units file#4764
estesp merged 1 commit intocontainerd:masterfrom
zhsj:cleanup-systemd

Conversation

@zhsj
Copy link
Copy Markdown
Contributor

@zhsj zhsj commented Nov 24, 2020

I think it's merged from cri, but we already have https://github.com/containerd/containerd/blob/master/containerd.service and Makefile is using it.

@install -m 644 containerd.service ${CRIDIR}/etc/systemd/system

@k8s-ci-robot
Copy link
Copy Markdown

Hi @zhsj. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Nov 24, 2020

Build succeeded.

@AkihiroSuda
Copy link
Copy Markdown
Member

/ok-to-test

Copy link
Copy Markdown
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit ddb47a3 into containerd:master Nov 25, 2020
@zhsj zhsj deleted the cleanup-systemd branch November 25, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants