Skip to content

docker: don’t hide pusher response error#4724

Merged
estesp merged 1 commit intocontainerd:masterfrom
tonistiigi:pusher-error
Nov 11, 2020
Merged

docker: don’t hide pusher response error#4724
estesp merged 1 commit intocontainerd:masterfrom
tonistiigi:pusher-error

Conversation

@tonistiigi
Copy link
Copy Markdown
Member

When write calls have succeeded on push but the request fails after that, the original error is hidden away and error just shows "no response". This PR keeps the original error.

Signed-off-by: Tonis Tiigi [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

Hi @tonistiigi. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Nov 11, 2020

Build succeeded.

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants