Skip to content

ctr: fix the incorrect image unmount error hint#4723

Merged
estesp merged 1 commit intocontainerd:masterfrom
lining2020x:ctr-error-hint
Nov 11, 2020
Merged

ctr: fix the incorrect image unmount error hint#4723
estesp merged 1 commit intocontainerd:masterfrom
lining2020x:ctr-error-hint

Conversation

@lining2020x
Copy link
Copy Markdown

Fix the following incorrect unmount error hint:
[root@localhost ~]# ctr images unmount
ctr: please provide a target path to mount to

Signed-off-by: Li Ning [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

Hi @lining2020. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Nov 11, 2020

Build succeeded.

@lining2020x
Copy link
Copy Markdown
Author

@fuweid Hello, please help review my PR. It's a very simple patch.

@fuweid
Copy link
Copy Markdown
Member

fuweid commented Nov 11, 2020

@lining2020 Could you mind to remove the part of commit message?

Fix the following incorrect unmount error hint:
[root@localhost ~]# ctr images unmount
ctr: please provide a target path to mount to

The change is LGTM

@lining2020x
Copy link
Copy Markdown
Author

@lining2020 Could you mind to remove the part of commit message?

Fix the following incorrect unmount error hint:
[root@localhost ~]# ctr images unmount
ctr: please provide a target path to mount to

The change is LGTM

OK, I will push a patch v2.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Nov 11, 2020

Build succeeded.

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 4dc698d into containerd:master Nov 11, 2020
@lining2020x lining2020x deleted the ctr-error-hint branch November 11, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants