ga: Linux Integration: extend timeout to 20 minutes#4721
Merged
estesp merged 1 commit intocontainerd:masterfrom Nov 10, 2020
Merged
ga: Linux Integration: extend timeout to 20 minutes#4721estesp merged 1 commit intocontainerd:masterfrom
estesp merged 1 commit intocontainerd:masterfrom
Conversation
CI was timing out after 15 minutes on the crun tests; extending the timeout to 20 minutes (we can make it shorter again if we know the exact time it takes to run) Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
Perhaps we should check why tests take longer to run (could be that more tests were added, or a regression in performance?) |
Member
Author
|
Hmmm... actually wondering if something is wrong, as it seems to have completed the tests, but got cancelled (some runaway process?) |
|
Build succeeded.
|
Member
Author
|
And of course, now it completes in 13 minutes 🤷♂️ |
AkihiroSuda
approved these changes
Nov 10, 2020
Member
|
I've noticed that overall things have been a bit sluggish in actions compared to when we first switched. We have also added quite a few extra runs/matrices, and crun definitely seems less performant than runc in general. I think setting the timeout higher is reasonable. We're about to add back in the test/root-test targets as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI was timing out after 15 minutes on the crun tests; extending the timeout to 20 minutes (we can make it shorter again if we know the exact time it takes to run)
e.g. https://github.com/containerd/containerd/pull/4578/checks?check_run_id=1380571893