Skip to content

install-runc: remove unused USESUDO variable#4718

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
thaJeztah:remove_sudo_remnants
Nov 10, 2020
Merged

install-runc: remove unused USESUDO variable#4718
crosbymichael merged 1 commit intocontainerd:masterfrom
thaJeztah:remove_sudo_remnants

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah commented Nov 10, 2020

This is no longer needed, as the script is already run with sudo (see 65df8db).

@thaJeztah
install-runc: remove unused USESUDO variable
1edeea7 
This is no longer needed, as the script is already run with sudo.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Nov 10, 2020

Build succeeded.

@thaJeztah
Copy link
Copy Markdown
Member Author

thaJeztah commented Nov 10, 2020

Windows failure shouldn't be related;

--- FAIL: TestContentClient (11.25s)
    --- FAIL: TestContentClient/ResumeCopySeeker (1.54s)
Error:         testsuite.go:677: ref ContentClient-n1/1/ref-0-4 locked: unavailable
Error:         helpers.go:67: drwxrwxrwx          0 C:\Users\RUNNER~1\AppData\Local\Temp\content-suite-ContentClient-183030746

dims
dims approved these changes Nov 10, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented Nov 10, 2020

LGTM

@crosbymichael crosbymichael merged commit 677aaad into containerd:master Nov 10, 2020
@thaJeztah thaJeztah deleted the remove_sudo_remnants branch November 10, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dims dims dims approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thaJeztah @crosbymichael @dims @AkihiroSuda