remove unused hack/* files#4713
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Nov 11, 2020
Merged
Conversation
|
Build succeeded.
|
- hack/test-cri-integration.sh : called from Makefile - hack/test-utils.sh : called from hack/test-cri-integration.sh - hack/utils.sh : called from hack/test-utils.sh Other files are no longer used and can be safely removed. Kube test-infra doesn't seem to require the removed file as well: https://github.com/kubernetes/test-infra/search?q=containerd+hack Signed-off-by: Akihiro Suda <[email protected]>
AkihiroSuda
force-pushed
the
remove-hack-unused
branch
from
bfab5aa to
0585213
Compare
thaJeztah
requested changes
Nov 10, 2020
| @@ -1,37 +0,0 @@ | |||
| #!/bin/bash | |||
Member
There was a problem hiding this comment.
This file is used in contrib/Dockerfile.test; https://github.com/containerd/containerd/blob/master/contrib/Dockerfile.test#L36
Are some of the other scripts useful for local development/testing?
Member
There was a problem hiding this comment.
Hmm, actually, looks like that Dockerfile may be broken because things moved around? (not sure, will have to check)
Member
Author
There was a problem hiding this comment.
That one is script/setup/install-runc, not hack/install/install-runc.sh
Member
There was a problem hiding this comment.
Ah, 🤦 thought they were renamed or so. thx
|
Build succeeded.
|
Member
|
will be back next week |
Member
|
/ok-to-test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Other files are no longer used and can be safely removed.
Kube test-infra doesn't seem to require the removed file as well: https://github.com/kubernetes/test-infra/search?q=containerd+hack