Skip to content

[release/1.4] update to golang 1.15.2#4711

Merged
mxpv merged 1 commit intocontainerd:release/1.4from
AkihiroSuda:go115-1.4
Nov 10, 2020
Merged

[release/1.4] update to golang 1.15.2#4711
mxpv merged 1 commit intocontainerd:release/1.4from
AkihiroSuda:go115-1.4

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda commented Nov 10, 2020

Cherry-pick #4050

@thaJeztah @AkihiroSuda
update to golang 1.15.2
e45f41e 
Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit d1c8d98)
Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda
Copy link
Copy Markdown
Member Author

AkihiroSuda commented Nov 10, 2020

@thaJeztah PTAL

@AkihiroSuda AkihiroSuda added this to the 1.4.2 milestone Nov 10, 2020
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Nov 10, 2020

Build succeeded.

Zyqsempai
Zyqsempai approved these changes Nov 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Copy Markdown
Member

thaJeztah commented Nov 10, 2020

Are we sure this is safe? I recall there were still reservations about go 1.14/1.15. The version of runc in this branch is also at v1.0.0-rc92, which was tested on Go 1.13; https://github.com/opencontainers/runc/blob/v1.0.0-rc92/Dockerfile#L1. Have changes been merged in runc after that release that relate to compatibility with Go 1.14/1.15?

At least, I know the selinux package has some changes pending release for Go 1.14 compatibility (opencontainers/selinux@v1.6.0...master (opencontainers/selinux#127)

/cc @tonistiigi @tiborvass (who had some scripts to check what syscalls are potentially called in a codebase, and could need fixing)

@AkihiroSuda
Copy link
Copy Markdown
Member Author

AkihiroSuda commented Nov 10, 2020 •
edited
Loading

runc rc92 is tested with Go 1.14 https://github.com/opencontainers/runc/blob/v1.0.0-rc92/.travis.yml#L5

mikebrow
mikebrow approved these changes Nov 10, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxpv mxpv merged commit 457dafa into containerd:release/1.4 Nov 10, 2020
@AkihiroSuda AkihiroSuda mentioned this pull request Nov 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxpv mxpv mxpv approved these changes

@mikebrow mikebrow mikebrow approved these changes

+1 more reviewer

@Zyqsempai Zyqsempai Zyqsempai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.4.2

Development

Successfully merging this pull request may close these issues.

5 participants

@AkihiroSuda @thaJeztah @mxpv @Zyqsempai @mikebrow