Skip to content

Do not hardcode "amd64" on LCOW and Windows-related files#4707

Merged
crosbymichael merged 1 commit intocontainerd:masterfrom
kzys:lcow-arm
Nov 17, 2020
Merged

Do not hardcode "amd64" on LCOW and Windows-related files#4707
crosbymichael merged 1 commit intocontainerd:masterfrom
kzys:lcow-arm

Conversation

@kzys
Copy link
Copy Markdown
Member

@kzys kzys commented Nov 9, 2020

Fixes #3281.

Signed-off-by: Kazuyoshi Kato [email protected]

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Nov 9, 2020

Hi @kzys. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Nov 9, 2020

Build succeeded.

mxpv
mxpv approved these changes Nov 9, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevpar
Copy link
Copy Markdown
Member

kevpar commented Nov 9, 2020

I'm not a maintainer, but LGTM

@kzys
Copy link
Copy Markdown
Member Author

kzys commented Nov 16, 2020

@jterry75 Can you take a look?

@crosbymichael
Copy link
Copy Markdown
Member

crosbymichael commented Nov 17, 2020

LGTM

@crosbymichael crosbymichael merged commit 340ab57 into containerd:master Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxpv mxpv mxpv approved these changes

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LCOW: should not hard code "amd64" architecture

5 participants

@kzys @k8s-ci-robot @kevpar @crosbymichael @mxpv