content: support filters on local.store#Walk()#4701
content: support filters on local.store#Walk()#4701AkihiroSuda merged 1 commit intocontainerd:masterfrom
Conversation
|
Hi @kzys. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Because metadata depends on local. I had to move this function from metadata.
There was a problem hiding this comment.
metadata/adaptors.go has the same function sadly. Is there a better place to have functions that are used from multiple adaptors?
There was a problem hiding this comment.
This is pretty small function, could just embed it if its only used once in this package.
There was a problem hiding this comment.
I'd like to keep this function as is rather than embedding.
|
Build succeeded.
|
kzys
force-pushed
the
content-store-filter
branch
from
ecae93c to
b8862cd
Compare
|
Build succeeded.
|
There was a problem hiding this comment.
Exported functions require a comment
There was a problem hiding this comment.
Sure. Added the doc comment.
While Walk() has been taking filter strings, it was not using the parameter. This change actually makes the filtering work. Signed-off-by: Kazuyoshi Kato <[email protected]>
kzys
force-pushed
the
content-store-filter
branch
from
b8862cd to
e74ace9
Compare
|
Build succeeded.
|
6 participants
While Walk() has been taking filter string, it was not using the parameter.
This change actually makes the filtering work.
Signed-off-by: Kazuyoshi Kato [email protected]