Skip to content

CRI security profile update for CRI graduation#4700

Merged
mikebrow merged 3 commits intocontainerd:masterfrom
mikebrow:cri-security-profile-update
Jan 12, 2021
Merged

CRI security profile update for CRI graduation#4700
mikebrow merged 3 commits intocontainerd:masterfrom
mikebrow:cri-security-profile-update

Conversation

@mikebrow
Copy link
Copy Markdown
Member

@mikebrow mikebrow commented Nov 6, 2020

Addressing new CRI api changes:

kubernetes/kubernetes#95876

@mrunalp @saschagrunert

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Nov 7, 2020

Build succeeded.

@mikebrow mikebrow force-pushed the cri-security-profile-update branch 2 times, most recently from 16172c3 to 34e9ba2 Compare November 7, 2020 00:10
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Nov 7, 2020

Build succeeded.

Copy link
Copy Markdown
Contributor

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread pkg/cri/server/container_create_linux.go Outdated
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Dec 3, 2020

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.

@mikebrow mikebrow force-pushed the cri-security-profile-update branch from 58f7a39 to 2cfc9ef Compare December 3, 2020 22:42
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Dec 3, 2020

Build succeeded.

@mikebrow mikebrow force-pushed the cri-security-profile-update branch from 2cfc9ef to a125878 Compare December 3, 2020 23:04
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Dec 3, 2020

Build succeeded.

@mikebrow
Copy link
Copy Markdown
Member Author

mikebrow commented Dec 3, 2020

would be nice if it printed the diff:

  These files were modified: 
   M go.sum
  Error: Process completed with exit code 1.

go mod tidy cleared it up

@mikebrow mikebrow force-pushed the cri-security-profile-update branch from a125878 to 9fc3d39 Compare December 4, 2020 21:16
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Dec 4, 2020

Build succeeded.

@mikebrow mikebrow force-pushed the cri-security-profile-update branch from 9fc3d39 to f12076c Compare December 7, 2020 18:34
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Dec 7, 2020

Build succeeded.

@mikebrow mikebrow force-pushed the cri-security-profile-update branch from f12076c to 0f97ddf Compare December 8, 2020 03:33
Signed-off-by: Mike Brown <[email protected]>
@mikebrow mikebrow force-pushed the cri-security-profile-update branch from 0f97ddf to 6467c33 Compare December 8, 2020 03:40
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Dec 8, 2020

Build succeeded.

@mikebrow
Copy link
Copy Markdown
Member Author

mikebrow commented Dec 8, 2020

@dmcgowan refactored, and ready for review.

Copy link
Copy Markdown
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow mikebrow merged commit 550b494 into containerd:master Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants