Skip to content

Conversation

@dweomer
Copy link
Contributor

@dweomer dweomer commented Nov 6, 2020

With container-selinux policy updated to 2.145+ (the default for Fedora 32+) we
can enable SELinux=Enforcing mode in the CI workflow and pass all integration
and CRI tests except one, see #4460,
which has been marked as skipped.

Tested locally with:

  • SELINUX=Enforcing vagrant up --provision-with=shell,selinux,test-integration
  • SELINUX=Enforcing vagrant up --provision-with=shell,selinux,test-cri

Signed-off-by: Jacob Blain Christen [email protected]

@k8s-ci-robot
Copy link

Hi @dweomer. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 6, 2020

Build succeeded.

@dweomer dweomer force-pushed the test-selinux-enforcing branch from 3eabf7e to d7f4d52 Compare November 6, 2020 20:11
@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 6, 2020

Build succeeded.

With container-selinux policy updated to 2.145+ (the default for Fedora 32+) we
can enable SELinux=Enforcing mode in the CI workflow and pass all integration
and CRI tests except one, see containerd#4460,
which has been marked as skipped.

Tested locally with:
- SELINUX=Enforcing vagrant up --provision-with=shell,selinux,test-integration
- SELINUX=Enforcing vagrant up --provision-with=shell,selinux,test-cri

Signed-off-by: Jacob Blain Christen <[email protected]>
@dweomer dweomer force-pushed the test-selinux-enforcing branch from d7f4d52 to a7f24b2 Compare November 9, 2020 16:37
@theopenlab-ci
Copy link

theopenlab-ci bot commented Nov 9, 2020

Build succeeded.

@dweomer
Copy link
Contributor Author

dweomer commented Nov 9, 2020

/cc @mikebrow

@k8s-ci-robot k8s-ci-robot requested a review from mikebrow November 9, 2020 18:31
@mikebrow
Copy link
Member

mikebrow commented Nov 9, 2020

/ok-to-test

Copy link
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crosbymichael
Copy link
Member

LGTM

@crosbymichael crosbymichael merged commit 1e7a690 into containerd:master Nov 10, 2020
@dweomer dweomer deleted the test-selinux-enforcing branch July 27, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants