[release/1.3 backport] ci: run critest target for all runtimes + use compatible critest version#4693
Merged
estesp merged 2 commits intocontainerd:release/1.3from Nov 6, 2020
Merged
Conversation
Signed-off-by: Samuel Karp <[email protected]>
This matches the version of critest used in containerd/cri's release/1.3 branch: https://github.com/containerd/cri/blob/9528e30672d7005b6b9a87b36b4e0553a5e9a5bb/hack/utils.sh#L20 Newer versions of critest require updates to containerd/cri: containerd/cri#1464 Signed-off-by: Samuel Karp <[email protected]>
Member
|
Great catch! 👍 |
|
Build succeeded.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4687 (including a bugfix where
EOF"was not seen as a valid heredoc end marker by bash, preventing the tests from running) and use a version of critest compatible with the vendored containerd/cri.cc @mikebrow @tianon