Skip to content

bug fix:#4646#4688

Merged
estesp merged 1 commit intocontainerd:masterfrom
YLonely:master
Nov 3, 2020
Merged

bug fix:#4646#4688
estesp merged 1 commit intocontainerd:masterfrom
YLonely:master

Conversation

@YLonely
Copy link
Copy Markdown
Contributor

@YLonely YLonely commented Nov 3, 2020

bug fix:#4646
invalid use of nil pointer in container restoring

@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Nov 3, 2020

Hi @YLonely. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Nov 3, 2020

Build succeeded.

@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Nov 3, 2020

Please sign off with full name

@YLonely
bug fix:containerd#3448
019148e 
Signed-off-by: Bowen Yan <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Nov 3, 2020

Build succeeded.

estesp
estesp approved these changes Nov 3, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit cb8c092 into containerd:master Nov 3, 2020
This was referenced Nov 19, 2020
Merged
Merged
@thaJeztah thaJeztah added cherry-picked/1.3.x cherry-picked/1.4.x PR commits are cherry picked into the release/1.4 branch and removed cherry-pick/1.3.x labels Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estesp estesp estesp approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

cherry-picked/1.4.x PR commits are cherry picked into the release/1.4 branch needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@YLonely @k8s-ci-robot @AkihiroSuda @estesp @thaJeztah