ci: run cri-integration target for all runtimes#4686
Merged
dmcgowan merged 1 commit intocontainerd:masterfrom Nov 3, 2020
Merged
ci: run cri-integration target for all runtimes#4686dmcgowan merged 1 commit intocontainerd:masterfrom
dmcgowan merged 1 commit intocontainerd:masterfrom
Conversation
Signed-off-by: Samuel Karp <[email protected]>
|
Build succeeded.
|
AkihiroSuda
approved these changes
Nov 3, 2020
Member
|
@samuelkarp will this help with firecracker-containerd testing? |
Member
Author
@dims Nope, this is just about making sure containerd's tests cover all three included runtimes (io.containerd.runtime.v1.linux, io.containerd.runc.v1, io.containerd.runc.v2). (firecracker-containerd isn't compatible with CRI yet; there are still a number of known gaps.) |
Member
|
gotcha. thanks @samuelkarp |
Member
|
1.4 cherry-pick for this is in containerd/cri#1603 (needs a re-vendor after that's merged) |
thaJeztah
added
cherry-picked/1.4.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @mikebrow