config path option to ctr for runtime#4673
Merged
crosbymichael merged 1 commit intocontainerd:masterfrom Oct 30, 2020
Merged
Conversation
Signed-off-by: Evan Hazlett <[email protected]>
|
Build succeeded.
|
egernst
approved these changes
Oct 29, 2020
Contributor
egernst
left a comment
egernst
left a comment
There was a problem hiding this comment.
Thanks Evan -- this looks good to me.
crosbymichael
approved these changes
Oct 30, 2020
Member
crosbymichael
left a comment
crosbymichael
left a comment
There was a problem hiding this comment.
LGTM
Initial it felt a little weird to see the cri runtime options being imported here, however, thinking about it just as a standard set of runtime opts that some runtimes share, I think it makes sense to have this in ctr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an option to pass the config path for an external runtime via
runtime-config-path.Signed-off-by: Evan Hazlett [email protected]