Update make snapshot annotations disabled by default#4665
Merged
fuweid merged 1 commit intocontainerd:masterfrom Oct 28, 2020
Merged
Update make snapshot annotations disabled by default#4665fuweid merged 1 commit intocontainerd:masterfrom
fuweid merged 1 commit intocontainerd:masterfrom
Conversation
This experimental feature should not be enabled by default as it is not used by any default snapshotters. Signed-off-by: Derek McGowan <[email protected]>
|
Build succeeded.
|
Member
|
@ktock PTAL |
Member
|
I agree with that we should have better ways for handling snapshot information as mentioned in #4610 (review) . cc @shahzzzam |
estesp
added
the
cherry-picked/1.4.x
This was referenced Nov 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This experimental feature should not be enabled by default as it is not used by any default snapshotters.
For 1.5 we have discussed other ways to handle storing this information rather than continuing to grow the number of labels.
This should also be backported to 1.4 along with the regression fix for labels over the size limit (containerd/cri#1572)