Skip to content

[release/1.4] cherry-pick: Update github.com/Microsoft/hcsshim to v0.8.10#4660

Merged
estesp merged 1 commit intocontainerd:release/1.4from
kevpar:1.4-update-hcsshim
Oct 27, 2020
Merged

[release/1.4] cherry-pick: Update github.com/Microsoft/hcsshim to v0.8.10#4660
estesp merged 1 commit intocontainerd:release/1.4from
kevpar:1.4-update-hcsshim

Conversation

@kevpar
Copy link
Copy Markdown
Member

@kevpar kevpar commented Oct 26, 2020

Cherry-pick #4585 for release/1.4.

Brings in a variety of changes, mostly to the containerd shim.

There is also a change to the Windows layer unpack code which fixes #4301.

Release link: https://github.com/microsoft/hcsshim/releases/tag/v0.8.10

Signed-off-by: Kevin Parsons [email protected]
(cherry picked from commit a043c0d)
Signed-off-by: Kevin Parsons [email protected]

Brings in a variety of changes, mostly to the containerd shim.

There is also a change to the Windows layer unpack code which fixes containerd#4301.

Release link: https://github.com/microsoft/hcsshim/releases/tag/v0.8.10

Signed-off-by: Kevin Parsons <[email protected]>
(cherry picked from commit a043c0d)
Signed-off-by: Kevin Parsons <[email protected]>
@k8s-ci-robot
Copy link
Copy Markdown

Hi @kevpar. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Oct 26, 2020

Build succeeded.

Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit... odd that it found vendor dependencies for a couple empty files.. see memory.go path.go

Copy link
Copy Markdown
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit ded2577 into containerd:release/1.4 Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants