CRI: always set unknown to false when handling exit event by zhuangqh · Pull Request #4656 · containerd/containerd

zhuangqh · 2020-10-26T09:59:13Z

Signed-off-by: jerryzhuang [email protected]

k8s-ci-robot · 2020-10-26T09:59:22Z

Hi @zhuangqh. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

theopenlab-ci · 2020-10-26T10:06:30Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 5m 58s (non-voting)

fuweid

LGTM

fuweid · 2020-10-26T10:09:32Z

/ok-to-test

AkihiroSuda · 2020-10-26T10:16:54Z

Signed-off-by: zhuangqh

Please use full name for signing

theopenlab-ci · 2020-10-26T11:26:23Z

Build succeeded.

containerd-build-arm64 : SUCCESS in 6m 03s (non-voting)

dims · 2020-10-26T12:32:37Z

LGTM

dims · 2020-10-26T12:33:08Z

yes, please cherry pick to previous versions!

dims · 2020-10-26T12:51:30Z

I am hoping this helps with kubernetes/kubernetes#51835

mikebrow

see comment

Signed-off-by: jerryzhuang <[email protected]>

fuweid

LGTM

estesp

LGTM

mikebrow · 2020-10-27T14:03:13Z

LGTM

backport from containerd/containerd#4656 Signed-off-by: jerryzhuang <[email protected]>

- Update to containerd 1.4.2 - Update Golang runtime to 1.15.5 Upstream containerd 1.4.2 release notes: https://github.com/containerd/containerd/releases/tag/v1.4.2 Welcome to the v1.4.2 release of containerd! ------------------------------------------------------ The second patch release for containerd 1.4 includes multiple minor fixes and updates. Notable Updates - Fix bug limiting the number of layers by default containerd/cri#1602 - Fix selinux shared memory issue by relabeling /dev/shm containerd/cri#1605 - Fix unknown state preventing removal of containers containerd/containerd#4656 - Fix nil pointer error when restoring checkpoint containerd/containerd#4754 - Improve image pull performance when using HTTP 1.1 containerd/containerd#4653 - Update default seccomp profile for pidfd containerd/containerd#4730 - Update Go to 1.15 Windows - Fix integer overflow on Windows containerd/containerd#4589 - Fix lcow snapshotter to read trailing tar data containerd/containerd#4628 Signed-off-by: Sebastiaan van Stijn <[email protected]>

NOTE: the Dockerfile currently uses a single version of Golang for all stages. This means that currently, all binaries are built with Go 1.13.x, including the containerd binary; upstream containerd switched to use Go 1.15. full diff: containerd/containerd@v1.4.1...v1.4.2 Release notes: Welcome to the v1.4.2 release of containerd! ------------------------------------------------------ The second patch release for containerd 1.4 includes multiple minor fixes and updates. Notable Updates - Fix bug limiting the number of layers by default containerd/cri#1602 - Fix selinux shared memory issue by relabeling /dev/shm containerd/cri#1605 - Fix unknown state preventing removal of containers containerd/containerd#4656 - Fix nil pointer error when restoring checkpoint containerd/containerd#4754 - Improve image pull performance when using HTTP 1.1 containerd/containerd#4653 - Update default seccomp profile for pidfd containerd/containerd#4730 - Update Go to 1.15 Windows - Fix integer overflow on Windows containerd/containerd#4589 - Fix lcow snapshotter to read trailing tar data containerd/containerd#4628 Signed-off-by: Sebastiaan van Stijn <[email protected]>

NOTE: the Dockerfile currently uses a single version of Golang for all stages. This means that currently, all binaries are built with Go 1.13.x, including the containerd binary; upstream containerd switched to use Go 1.15. full diff: containerd/containerd@v1.4.1...v1.4.2 Release notes: Welcome to the v1.4.2 release of containerd! ------------------------------------------------------ The second patch release for containerd 1.4 includes multiple minor fixes and updates. Notable Updates - Fix bug limiting the number of layers by default containerd/cri#1602 - Fix selinux shared memory issue by relabeling /dev/shm containerd/cri#1605 - Fix unknown state preventing removal of containers containerd/containerd#4656 - Fix nil pointer error when restoring checkpoint containerd/containerd#4754 - Improve image pull performance when using HTTP 1.1 containerd/containerd#4653 - Update default seccomp profile for pidfd containerd/containerd#4730 - Update Go to 1.15 Windows - Fix integer overflow on Windows containerd/containerd#4589 - Fix lcow snapshotter to read trailing tar data containerd/containerd#4628 Signed-off-by: Sebastiaan van Stijn <[email protected]> Upstream-commit: 703951197c3338631ee0529dd9dd814d16f037f0 Component: engine

This version includes a fix for CVE-2020-15257 as well as a bugfix which could prevent issues with Pods remaining in `Terminating` state. Fixes: #2955 Fixes: #2955 See: https://github.com/containerd/containerd/releases/tag/v1.4.3 See: GHSA-36xw-fx78-c5r4 See: containerd/containerd#4656

This version includes a fix for CVE-2020-15257 as well as a bugfix which could prevent issues with Pods remaining in `Terminating` state. Fixes: #2955 Fixes: #2955 See: https://github.com/containerd/containerd/releases/tag/v1.4.3 See: GHSA-36xw-fx78-c5r4 See: containerd/containerd#4656 See: #2956

- Update to containerd 1.4.2 - Update Golang runtime to 1.15.5 Upstream containerd 1.4.2 release notes: https://github.com/containerd/containerd/releases/tag/v1.4.2 Welcome to the v1.4.2 release of containerd! ------------------------------------------------------ The second patch release for containerd 1.4 includes multiple minor fixes and updates. Notable Updates - Fix bug limiting the number of layers by default containerd/cri#1602 - Fix selinux shared memory issue by relabeling /dev/shm containerd/cri#1605 - Fix unknown state preventing removal of containers containerd/containerd#4656 - Fix nil pointer error when restoring checkpoint containerd/containerd#4754 - Improve image pull performance when using HTTP 1.1 containerd/containerd#4653 - Update default seccomp profile for pidfd containerd/containerd#4730 - Update Go to 1.15 Windows - Fix integer overflow on Windows containerd/containerd#4589 - Fix lcow snapshotter to read trailing tar data containerd/containerd#4628 Signed-off-by: Sebastiaan van Stijn <[email protected]>

NOTE: the Dockerfile currently uses a single version of Golang for all stages. This means that currently, all binaries are built with Go 1.13.x, including the containerd binary; upstream containerd switched to use Go 1.15. full diff: containerd/containerd@v1.4.1...v1.4.2 Release notes: Welcome to the v1.4.2 release of containerd! ------------------------------------------------------ The second patch release for containerd 1.4 includes multiple minor fixes and updates. Notable Updates - Fix bug limiting the number of layers by default containerd/cri#1602 - Fix selinux shared memory issue by relabeling /dev/shm containerd/cri#1605 - Fix unknown state preventing removal of containers containerd/containerd#4656 - Fix nil pointer error when restoring checkpoint containerd/containerd#4754 - Improve image pull performance when using HTTP 1.1 containerd/containerd#4653 - Update default seccomp profile for pidfd containerd/containerd#4730 - Update Go to 1.15 Windows - Fix integer overflow on Windows containerd/containerd#4589 - Fix lcow snapshotter to read trailing tar data containerd/containerd#4628 Signed-off-by: Sebastiaan van Stijn <[email protected]> (cherry picked from commit 7039511) Signed-off-by: Sebastiaan van Stijn <[email protected]>

k8s-ci-robot added the needs-ok-to-test label Oct 26, 2020

fuweid added cherry-pick/1.3.x labels Oct 26, 2020

fuweid approved these changes Oct 26, 2020

View reviewed changes

k8s-ci-robot added ok-to-test and removed needs-ok-to-test labels Oct 26, 2020

zhuangqh force-pushed the fix-unknown-state branch from 2ee8efa to 8da0fd0 Compare October 26, 2020 11:18

AkihiroSuda approved these changes Oct 26, 2020

View reviewed changes

fuweid requested a review from mikebrow October 26, 2020 11:54

mikebrow reviewed Oct 26, 2020

View reviewed changes

Comment thread pkg/cri/server/events.go Outdated

zhuangqh force-pushed the fix-unknown-state branch from 8da0fd0 to 5daa1ce Compare October 27, 2020 01:55

zhuangqh requested a review from mikebrow October 27, 2020 01:59

fix: always set unknown to false when handling exit event

30c9add

Signed-off-by: jerryzhuang <[email protected]>

zhuangqh force-pushed the fix-unknown-state branch from 5daa1ce to 30c9add Compare October 27, 2020 02:50

fuweid approved these changes Oct 27, 2020

View reviewed changes

estesp approved these changes Oct 27, 2020

View reviewed changes

estesp merged commit 839b136 into containerd:master Oct 27, 2020

zhuangqh added a commit to zhuangqh/cri that referenced this pull request Oct 28, 2020

fix: always set unknown to false when handling exit event

04bc6cc

backport from containerd/containerd#4656 Signed-off-by: jerryzhuang <[email protected]>

zhuangqh mentioned this pull request Oct 28, 2020

[release/1.4 backport] fix: always set unknown to false when handling exit event containerd/cri#1600

Merged

zhuangqh added a commit to zhuangqh/cri that referenced this pull request Oct 28, 2020

fix: always set unknown to false when handling exit event

7973126

backport from containerd/containerd#4656 Signed-off-by: jerryzhuang <[email protected]>

thaJeztah mentioned this pull request Nov 26, 2020

release 1.4.3 (CVE-2020-15257) docker/containerd-packaging#204

Merged

thaJeztah mentioned this pull request Nov 26, 2020

update containerd binary to v1.4.2 moby/moby#41718

Merged

thaJeztah added cherry-picked/1.4.x PR commits are cherry picked into the release/1.4 branch and removed cherry-pick/1.4.x labels Nov 26, 2020

NicolasT mentioned this pull request Dec 1, 2020

Upgrade containerd to 1.4.3 scality/metalk8s#2955

Closed

NicolasT mentioned this pull request Dec 1, 2020

packages: bump containerd to 1.4.3 scality/metalk8s#2956

Merged

snir911 mentioned this pull request Jul 22, 2021

stable 2.1 | adapt to new cri containerd cni tarball link kata-containers/tests#3744

Merged

Conversation

zhuangqh commented Oct 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Oct 26, 2020

Uh oh!

theopenlab-ci Bot commented Oct 26, 2020

Uh oh!

fuweid left a comment

Choose a reason for hiding this comment

Uh oh!

fuweid commented Oct 26, 2020

Uh oh!

AkihiroSuda commented Oct 26, 2020

Uh oh!

theopenlab-ci Bot commented Oct 26, 2020

Uh oh!

dims commented Oct 26, 2020

Uh oh!

dims commented Oct 26, 2020

Uh oh!

dims commented Oct 26, 2020

Uh oh!

mikebrow left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

fuweid left a comment

Choose a reason for hiding this comment

Uh oh!

estesp left a comment

Choose a reason for hiding this comment

Uh oh!

mikebrow commented Oct 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

zhuangqh commented Oct 26, 2020 •

edited

Loading