Skip to content

Cleanup CI#4637

Merged
estesp merged 1 commit intocontainerd:masterfrom
mxpv:ci
Oct 16, 2020
Merged

Cleanup CI#4637
estesp merged 1 commit intocontainerd:masterfrom
mxpv:ci

Conversation

@mxpv
Copy link
Copy Markdown
Member

@mxpv mxpv commented Oct 15, 2020

echo "::set-env name=GOPATH::${{ github.workspace }}" is now deprecated on Github, so this updates script to use the suggested one echo "GOPATH=${{ github.workspace }}" >> $GITHUB_ENV

Also this PR does some cleanup to avoid code repetition.

Signed-off-by: Maksym Pavlenko [email protected]

Signed-off-by: Maksym Pavlenko <[email protected]>
@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Oct 15, 2020

Build succeeded.

@mxpv mxpv marked this pull request as ready for review October 15, 2020 23:25
Copy link
Copy Markdown
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit f8e3c8f into containerd:master Oct 16, 2020
@mxpv mxpv deleted the ci branch October 20, 2020 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants