Filter snapshotter labels passed to wrapper of WithNewSnapshot#4635
Merged
mxpv merged 1 commit intocontainerd:masterfrom Oct 15, 2020
Merged
Filter snapshotter labels passed to wrapper of WithNewSnapshot#4635mxpv merged 1 commit intocontainerd:masterfrom
mxpv merged 1 commit intocontainerd:masterfrom
Conversation
Made a change yesterday that passed through snapshotter labels into the wrapper of WithNewSnapshot, but it passed the entirety of the annotations into the snapshotter. This change just filters the set that we care about down to snapshotter specific labels. Will probably be future changes to add some more labels for LCOW/WCOW and the corresponding behavior for these new labels. Signed-off-by: Daniel Canter <[email protected]>
|
Hi @dcantah. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build succeeded.
|
Member
|
/ok-to-test |
mxpv
approved these changes
Oct 15, 2020
7 tasks
anmaxvl
added a commit
to anmaxvl/cri
that referenced
this pull request
Nov 2, 2021
This PR replays change originally done in: containerd/containerd#4635 Signed-off-by: Maksim An <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made a change yesterday (#4630) that passed through snapshotter labels into the wrapper of WithNewSnapshot, but it passed the entirety of the annotations into the snapshotter. This change just filters the set that we care about down to snapshotter specific labels.
Will probably be future changes to add some more labels for LCOW/WCOW and the corresponding
behavior for these new labels.