Skip to content

Fixes to run node e2e tests#4627

Merged
estesp merged 1 commit intocontainerd:masterfrom
dmcgowan:test-add-tarball-check
Oct 19, 2020
Merged

Fixes to run node e2e tests#4627
estesp merged 1 commit intocontainerd:masterfrom
dmcgowan:test-add-tarball-check

Conversation

@dmcgowan
Copy link
Copy Markdown
Member

Running through tests first

@k8s-ci-robot
Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dmcgowan
Copy link
Copy Markdown
Member Author

/test all

@k8s-ci-robot
Copy link
Copy Markdown

@dmcgowan: No jobs can be run with /test all.
The following commands are available to trigger jobs:

  • /test pull-containerd-build
  • /test pull-containerd-node-e2e
Details

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dmcgowan
Copy link
Copy Markdown
Member Author

/test pull-containerd-build

@dmcgowan
Copy link
Copy Markdown
Member Author

/test pull-containerd-node-e2e

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Oct 13, 2020

Build succeeded.

@dmcgowan
Copy link
Copy Markdown
Member Author

/test pull-containerd-node-e2e

@dmcgowan dmcgowan force-pushed the test-add-tarball-check branch from 5f08d18 to 25d641d Compare October 14, 2020 00:43
@dmcgowan
Copy link
Copy Markdown
Member Author

/test pull-containerd-node-e2e

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Oct 14, 2020

Build succeeded.

@dmcgowan dmcgowan force-pushed the test-add-tarball-check branch from 25d641d to 83f4774 Compare October 16, 2020 19:25
@dmcgowan
Copy link
Copy Markdown
Member Author

/test pull-containerd-node-e2e

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Oct 16, 2020

Build succeeded.

@dmcgowan dmcgowan force-pushed the test-add-tarball-check branch from 83f4774 to 29c55ac Compare October 16, 2020 19:47
@dmcgowan
Copy link
Copy Markdown
Member Author

/test pull-containerd-node-e2e

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Oct 16, 2020

Build succeeded.

@dmcgowan dmcgowan force-pushed the test-add-tarball-check branch from 29c55ac to 283a717 Compare October 16, 2020 20:03
@dmcgowan
Copy link
Copy Markdown
Member Author

/test pull-containerd-node-e2e

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Oct 16, 2020

Build succeeded.

@dmcgowan dmcgowan force-pushed the test-add-tarball-check branch from 283a717 to 04a3f7c Compare October 16, 2020 20:33
@dmcgowan
Copy link
Copy Markdown
Member Author

/test pull-containerd-node-e2e

@theopenlab-ci
Copy link
Copy Markdown

theopenlab-ci Bot commented Oct 16, 2020

Build succeeded.

@k8s-ci-robot
Copy link
Copy Markdown

@dmcgowan: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-containerd-node-e2e 04a3f7c link /test pull-containerd-node-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mikebrow
Copy link
Copy Markdown
Member

Possible fix here kubernetes/kubernetes#95613 see kubernetes/kubernetes#95321

@dmcgowan dmcgowan changed the title Add tarball value check in test build Fixes to run node e2e tests Oct 16, 2020
@dmcgowan dmcgowan marked this pull request as ready for review October 16, 2020 21:38
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikebrow
Copy link
Copy Markdown
Member

mikebrow commented Oct 16, 2020

we can merge this fix now imo.. the failures are not due to this PR or the merging of CRI into containerd.

@mikebrow
Copy link
Copy Markdown
Member

/test

@k8s-ci-robot
Copy link
Copy Markdown

@mikebrow: The /test command needs one or more targets.
The following commands are available to trigger jobs:

  • /test pull-containerd-build
  • /test pull-containerd-node-e2e
Details

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mikebrow
Copy link
Copy Markdown
Member

/test pull-containerd-build

@dims
Copy link
Copy Markdown
Member

dims commented Oct 19, 2020

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit f36f313 into containerd:master Oct 19, 2020
@dmcgowan dmcgowan deleted the test-add-tarball-check branch April 20, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants