Updating to latest docker #4626
Conversation
|
Build succeeded.
|
dims
force-pushed
the
bump-to-newer-docker-tag
branch
from
37c0c59 to
16a64c7
Compare
|
Build succeeded.
|
dims
force-pushed
the
bump-to-newer-docker-tag
branch
from
16a64c7 to
b68fafe
Compare
|
Build succeeded.
|
dims
force-pushed
the
bump-to-newer-docker-tag
branch
from
b68fafe to
a07c999
Compare
|
Build succeeded.
|
Signed-off-by: Davanum Srinivas <[email protected]>
dims
force-pushed
the
bump-to-newer-docker-tag
branch
from
a07c999 to
4044ca9
Compare
|
Build succeeded.
|
Signed-off-by: Davanum Srinivas <[email protected]>
|
Build succeeded.
|
| # cri dependencies | ||
| github.com/davecgh/go-spew v1.1.1 | ||
| github.com/docker/docker 4634ce647cf2ce2c6031129ccd109e557244986f | ||
| github.com/docker/docker 9c15e82f19b0ad3c5fe8617a8ec2dddc6639f40a |
There was a problem hiding this comment.
Looks like the updated docker vendor does not bring in any changes; was there a specific need to update?
There was a problem hiding this comment.
the SHA was older than the one in k/k, so was trying to update to newer one. am ok to leave this as-is.
i had to jump between versions of containerd/console x/sys and docker/docker to find the right combination that works and i have to do the same thing in cadvisor and k/k, i thought i would file this here first :)
There was a problem hiding this comment.
Looks like there's only two packages used from docker; perhaps worth evaluating if those could be separated 🤔 (the "contrib" files are vendored because they contain C files, which vndr always vendors)
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM, but worth looking if we can cut the dependency (perhaps moving out some of those packages)
|
@thaJeztah ack, i'll follow up with a PR to remove docker/docker, looks doable :) let's get this in |
4 participants
Initial attempt was to update to v19.03.13 docker. But ended up in trouble because of conflicting dependencies. So updated to latest moby/moby instead:
moby/moby@4634ce6...9c15e82
Needed to bring in newer
golang.org/x/sysbecause of:moby/moby@c3a0a37
Signed-off-by: Davanum Srinivas [email protected]